Add Pressure Gradient design document #226
Conversation
sbrus89
requested review from
alicebarthel,
katsmith133,
mark-petersen,
mwarusz,
philipwjones,
vanroekel and
xylar
vanroekel
left a comment
vanroekel
left a comment
There was a problem hiding this comment.
Looks good, just a couple tiny questions from me.
|
Test compiled and posted here. |
components/omega/doc/design/PGrad.md
Outdated
| ## Verification and Testing | ||
|
|
||
| ### Test: Spatial convergence to exact solution | ||
| For a given analytical $v$, $h$, and $b$, the spatial convergence of the pressure gradient can be assessed by computing errors on progressively finer meshes. |
There was a problem hiding this comment.
I think maybe this should be fleshed out a bit more. What analytic test would we use?
There was a problem hiding this comment.
I revised this part slightly. I think we just need to specify arbitrary functions for the
sbrus89
force-pushed
the
omega/pgrad-design
branch
4 times, most recently
from
674c345 to
16c3c49
Compare
sbrus89
force-pushed
the
omega/pgrad-design
branch
from
16c3c49 to
c32bbb2
Compare
|
Latest version compiled here. |
mark-petersen
left a comment
mark-petersen
left a comment
There was a problem hiding this comment.
Thanks for your work on this. It looks great!
Co-authored-by: Mark Petersen <[email protected]>
|
|
||
| ### 2.2 Requirement: Initial support for a simple centered pressure gradient | ||
|
|
||
| For initial global cases without ice shelf cavities, the pressure and geopotential gradients will be computed with a simple centered difference approximation. In later versions of Omega, one or more high-order pressure gradients will be implemented and will replace the centered approach in production runs. |
There was a problem hiding this comment.
one or more seems different from the next requirement where Adcroft 2008 is mentioned. Is the plan to leave open for multiple options?
There was a problem hiding this comment.
the hedge Xylar proposed below seems like a good choice will->may and resolves the inconsistency
7 participants
This PR adds the design document for the pressure gradient module for Omega-1. Compiled version here.
Checklist